RFR: 8246104: Some complex text doesn't render correctly on macOS [v8]

Phil Race prr at openjdk.org
Thu Apr 6 17:45:17 UTC 2023


On Thu, 6 Apr 2023 16:49:34 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix ranges
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFactory.java line 245:
> 
>> 243:          * Probably this should be handled elsewhere
>> 244:          */
>> 245:         if (isMacOSX && name.startsWith("System ")) {
> 
> `name` can be null, so you need a null check here. This is the cause of the unit test failures.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1067#discussion_r1160085423


More information about the openjfx-dev mailing list