RFR: 8246104: Some complex text doesn't render correctly on macOS

[Johan Vos]

On Fri, 7 Apr 2023 08:15:08 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> @johanvos You might want to take a look at this, since it supersedes your earlier PR #547.
>
>> @johanvos You might want to take a look at this, since it supersedes your earlier PR #547.
> 
> It also supersedes #553

> @johanvos did you have any comments on this PR?

This approach is a much better approach to fix PR #547 and PR #553
I had a high-level look at the diff, and it is clean and understandable (also, great explanation in the description of the PR, that really helps in understanding the PR!).
I added one comment about the macos-specific test in PrismFontFactory, but I think the proposed solution is the most elegant approach to match the macos concepts to the JavaFX concepts.
I checked the previous review comments and the replies, all looking good.

@jperedadnr did some UI tests, and we see the major improvements as well.
Excellent work!

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1067#issuecomment-1500078466