RFR: JDK-8224260: ChangeListener not triggered when adding a new listener in invalidated method

Fri Apr 7 21:56:52 UTC 2023

On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> Fixes three issues in ExpressionHelper:
> 
> - Current Value was not retained when changing from SingleChange to Generic, this can lead to missed changes
> - Current Value was not retained when changing from Generic to SingleChange, this can lead to missed changes
> - Current Value was not cleared when last change listener was removed in Generic variant, resulting in an older value being referenced and not becoming eligible for GC until either a ChangeListener is added again, or sufficient InvalidationListeners are removed to switch to the SingleInvalidation implementation...

Looks good. I confirm the new test fails without the fix and passes with the fix.

@nlisker would you be willing to also review this?

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1078#pullrequestreview-1376619837
PR Comment: https://git.openjdk.org/jfx/pull/1078#issuecomment-1500676550