RFR: 8303740 JavaFX - Leak in Logging, Logging remembers last exception [v2]

[Kevin Rushforth]

On Thu, 23 Mar 2023 08:31:41 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> When an exception is logged in JavaFX, then the exception is kept in a reference.
>> This way, always the last logged exception is retained.
>> 
>> This is a memory-leak.
>> This was done to write unit-tests to ensure certain error-cases are logged.
>> 
>> A simple fix is, to add a flag, to enable/disable retaining the exception.
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8303740
>   Added changes based on code review

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1053#pullrequestreview-1376639795