RFR: JDK-8303897 ObservableValue's when binding should only invalidate when strictly needed [v2]
John Hendrikx
jhendrikx at openjdk.org
Sun Apr 9 21:15:29 UTC 2023
On Sun, 9 Apr 2023 16:46:44 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix review comments
>
> modules/javafx.base/src/test/java/test/javafx/beans/value/ObservableValueWhenTest.java line 81:
>
>> 79: condition.set(true);
>> 80:
>> 81: assertEquals(List.of(), observedMappings);
>
> Is this part necessary? The method that starts with `true` already checks the transition to `false`. That is, after line 63 `condition.set(true);`, aren't we at the exact same state that the other method starts at?
>
> Same comment for the observed variant.
It's not strictly needed, I just want to eliminate any possibility that a different initial state could affect the results.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1056#discussion_r1161341624
More information about the openjfx-dev
mailing list