RFR: JDK-8224260: ChangeListener not triggered when adding a new listener in invalidated method

Michael Strauß mstrauss at openjdk.org
Mon Apr 10 19:26:22 UTC 2023


On Thu, 30 Mar 2023 21:53:48 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> Fixes three issues in ExpressionHelper:
> 
> - Current Value was not retained when changing from SingleChange to Generic, this can lead to missed changes
> - Current Value was not retained when changing from Generic to SingleChange, this can lead to missed changes
> - Current Value was not cleared when last change listener was removed in Generic variant, resulting in an older value being referenced and not becoming eligible for GC until either a ChangeListener is added again, or sufficient InvalidationListeners are removed to switch to the SingleInvalidation implementation...

This is a pretty straightforward change. I can confirm that it works as I would expect it to work.

-------------

Marked as reviewed by mstrauss (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1078#pullrequestreview-1378015757


More information about the openjfx-dev mailing list