RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v7]

[Martin Fox]

On Wed, 5 Apr 2023 12:36:37 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added manual cross-platform keyboard handling test
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassKey.m line 195:
> 
>> 193:     }
>> 194: 
>> 195:     if (keyCode >= 0x00 && keyCode <= 0x32)
> 
> Add a comment? like `// Null to [Space]`

This are Mac virtual key code constants, not characters, so this covers the keyboard from 'A' to 'grave'. I added a comment clarifying this as well as the 0x5D to 0x5F range (which are JIS keys). I could change the numbers from hex to the symbolic constants defined in Events.h but keeping them in hex makes it easier to compare to the table.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/425#discussion_r1162042846