RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v7]

[Martin Fox]

On Wed, 5 Apr 2023 12:39:28 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added manual cross-platform keyboard handling test
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassKey.m line 195:
> 
>> 193:     }
>> 194: 
>> 195:     if (keyCode >= 0x00 && keyCode <= 0x32)
> 
> out of curiosity, why not?
> ` if ((keyCode >= 0x00 && keyCode <= 0x32) || (keyCode >= 0x5D && keyCode <= 0x5F))`

No real reason, it was probably just easier to write it like this when I was originally going through the table and sorting out the ranges. I do prefer separating out conditionals when I can since it makes it easier to set debug breakpoints (not that that matters here).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/425#discussion_r1162045857