RFR: JDK-8304933: BitSet (used for CSS pseudo class states) listener management is incorrect

[Michael Strauß]

On Mon, 27 Mar 2023 14:24:42 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> BitSet uses the SetListenerHelper abstraction to prevent allocating the listener arrays.
> 
> When removing listeners, the newly returned listener helper (which may be different from the one called) is not reassigned. This effectively means that removing the listener does not happen.
> 
> This fix correctly assigns the potentially changed SetListenerHelper instance to BitSet's helper field after listener removal.

modules/javafx.graphics/src/shims/java/com/sun/javafx/css/BitSetShim.java line 95:

> 93:     }
> 94: 
> 95:     // Generated delegate methods:

Very minor: these methods are not generated as part of the build process that would warrant pointing it out.

modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/BitSetTest.java line 1:

> 1: package test.com.sun.javafx.css;

This file is missing a copyright header.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1071#discussion_r1162093778
PR Review Comment: https://git.openjdk.org/jfx/pull/1071#discussion_r1162092570