RFR: JDK-8304933: BitSet (used for CSS pseudo class states) listener management is incorrect

Mon Apr 10 21:46:48 UTC 2023

On Mon, 27 Mar 2023 14:24:42 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> BitSet uses the SetListenerHelper abstraction to prevent allocating the listener arrays.
> 
> When removing listeners, the newly returned listener helper (which may be different from the one called) is not reassigned. This effectively means that removing the listener does not happen.
> 
> This fix correctly assigns the potentially changed SetListenerHelper instance to BitSet's helper field after listener removal.

I'll re-approve once the missing copyright header is added.

-------------

Changes requested by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1071#pullrequestreview-1378170488