RFR: JDK-8304933: BitSet (used for CSS pseudo class states) listener management is incorrect [v2]
John Hendrikx
jhendrikx at openjdk.org
Mon Apr 10 23:08:31 UTC 2023
> BitSet uses the SetListenerHelper abstraction to prevent allocating the listener arrays.
>
> When removing listeners, the newly returned listener helper (which may be different from the one called) is not reassigned. This effectively means that removing the listener does not happen.
>
> This fix correctly assigns the potentially changed SetListenerHelper instance to BitSet's helper field after listener removal.
John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
- Change comment
- Add copyright header
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1071/files
- new: https://git.openjdk.org/jfx/pull/1071/files/018f4bf3..10d51da2
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1071&range=01
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1071&range=00-01
Stats: 26 lines in 2 files changed: 25 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jfx/pull/1071.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1071/head:pull/1071
PR: https://git.openjdk.org/jfx/pull/1071
More information about the openjfx-dev
mailing list