RFR: JDK-8304933: BitSet (used for CSS pseudo class states) listener management is incorrect [v2]
Michael Strauß
mstrauss at openjdk.org
Mon Apr 10 23:43:42 UTC 2023
On Mon, 10 Apr 2023 23:08:31 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> BitSet uses the SetListenerHelper abstraction to prevent allocating the listener arrays.
>>
>> When removing listeners, the newly returned listener helper (which may be different from the one called) is not reassigned. This effectively means that removing the listener does not happen.
>>
>> This fix correctly assigns the potentially changed SetListenerHelper instance to BitSet's helper field after listener removal.
>
> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
>
> - Change comment
> - Add copyright header
Marked as reviewed by mstrauss (Committer).
-------------
PR Review: https://git.openjdk.org/jfx/pull/1071#pullrequestreview-1378255436
More information about the openjfx-dev
mailing list