RFR: JDK-8224260: ChangeListener not triggered when adding a new listener in invalidated method [v2]

Nir Lisker nlisker at openjdk.org
Tue Apr 11 08:31:53 UTC 2023


On Tue, 11 Apr 2023 07:57:56 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Fixes three issues in ExpressionHelper:
>> 
>> - Current Value was not retained when changing from SingleChange to Generic, this can lead to missed changes
>> - Current Value was not retained when changing from Generic to SingleChange, this can lead to missed changes
>> - Current Value was not cleared when last change listener was removed in Generic variant, resulting in an older value being referenced and not becoming eligible for GC until either a ChangeListener is added again, or sufficient InvalidationListeners are removed to switch to the SingleInvalidation implementation...
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Doc improvements

Marked as reviewed by nlisker (Reviewer).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1078#pullrequestreview-1378710264


More information about the openjfx-dev mailing list