RFR: 8088594: NullPointerException on showing submenu of a contextmenu [v3]

Karthik P K kpk at openjdk.org
Tue Apr 11 12:18:55 UTC 2023


On Mon, 10 Apr 2023 07:21:21 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Add space between if and (
>>  - Address review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ContextMenuSkin.java line 204:
> 
>> 202:         root.idProperty().unbind();
>> 203:         root.styleProperty().unbind();
>> 204:         if(root instanceof ContextMenuContent) {
> 
> Minor: add a space between `if` and `(`

Updated code. Please check

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1082#discussion_r1162728540


More information about the openjfx-dev mailing list