RFR: 8088594: NullPointerException on showing submenu of a contextmenu [v4]

Andy Goryachev angorya at openjdk.org
Wed Apr 12 15:14:05 UTC 2023


On Wed, 12 Apr 2023 05:08:46 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> When custom skin was loaded, the listeners added in `ContextMenuContent` class while loading the default skin were not removed. This was causing the NPE when outdated listeners were invoked.
>> 
>> Updated the code to dispose listeners in the `dispose` method of `ContextMenuSkin` so that when new skin is loaded, listeners added in the old skin are removed.
>> 
>> Added system test to validate the fix.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address code review

Marked as reviewed by angorya (Committer).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1082#pullrequestreview-1381545124


More information about the openjfx-dev mailing list