RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v7]

Jose Pereda jpereda at openjdk.org
Wed Apr 12 15:43:39 UTC 2023


On Wed, 5 Apr 2023 12:38:36 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added manual cross-platform keyboard handling test
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassKey.m line 198:
> 
>> 196:         return YES;
>> 197: 
>> 198:     if (keyCode >= 0x5D && keyCode <= 0x5F)
> 
> same: `'' to ']'`

okay, fixed

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/425#discussion_r1164304706


More information about the openjfx-dev mailing list