RFR: JDK-8305885: Use ReadOnly*PropertyBase class where possible [v2]

John Hendrikx jhendrikx at openjdk.org
Sat Apr 15 01:39:39 UTC 2023


On Sat, 15 Apr 2023 01:26:13 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> John Hendrikx has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Use property base classes where possible
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/TreeShowingExpression.java line 44:
> 
>> 42:  * an observable form.
>> 43:  */
>> 44: public class TreeShowingExpression extends ReadOnlyBooleanPropertyBase {
> 
> Maybe you could rename the class to `TreeShowingProperty`?

Yeah, that would definitely be better.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1092#discussion_r1167354675


More information about the openjfx-dev mailing list