RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v3]

[John Hendrikx]

On Sun, 16 Apr 2023 03:59:09 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Improve generics on ObservableValueBase
>>  - Improve generics
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/OldValueCachingListenerList.java line 164:
> 
>> 162:     }
>> 163: 
>> 164:     private void callInvalidationListener(ObservableValue<?> instance, InvalidationListener listener) {
> 
> This method is identical to `ListenerList.callInvalidationListener`.

Yes, it would be good to just put these static somewhere. They don't really fit well in the manager class (as the List class which doesn't depend on manager would need to call them there), and the other way around is also odd, given that I only need to call them when not in "list" mode. Still, putting them package private in the ListenerListBase could work....

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r1167755526