RFR: 8306021: Add event handler management to EventTarget [v2]
Nir Lisker
nlisker at openjdk.org
Mon Apr 17 05:08:44 UTC 2023
On Mon, 17 Apr 2023 04:51:03 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
> I don't know what "visual events" are, maybe input events?
I thought something like that too, including scroll and touch events. Maybe @kevinrushforth knows.
> Anyway, the added value of this entire javadoc seems to be rather low, I'm inclined to just remove it entirely.
I don't think I mind removing it. My more general concern is that it's not obvious what events can be registered on different `EventTarget`s.
> By the way, there's a great documentation of the JavaFX event system at https://docs.oracle.com/javase/8/javafx/events-tutorial/events.htm. It would be really helpful if we could add this to the JavaFX codebase in the future.
Yes, I had an idea to link to the tutorials when working on controls documentation (https://bugs.openjdk.org/browse/JDK-8252550). The problem is that we don't have access to them and can't update them if they are out of date. Embedding them is probably too verbose. Linking looks like the better option.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1090#discussion_r1168168270
More information about the openjfx-dev
mailing list