RFR: 8299335: Monkey Tester Application
Kevin Rushforth
kcr at openjdk.org
Wed Apr 19 12:22:55 UTC 2023
On Tue, 18 Apr 2023 20:12:01 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
> Monkey Tester - a JavaFX application designed to support ad-hoc testing of JavaFX controls.
>
> Feedback and suggestions are always welcome.
>
> 
I'll do some testing, and a proper review, in the next few days. I did leave comments on a couple of the non-source-code files.
tests/manual/monkey/.gitignore line 1:
> 1: /bin/
As mentioned in the general comments, I recommend to delete this file.
tests/manual/monkey/README.md line 45:
> 43: ## Contact
> 44:
> 45: andy.goryachev at oracle.com
We don't normally put an individual developer's email address in a file in our repo.
tests/manual/monkey/build.xml line 3:
> 1: <?xml version="1.0" encoding="UTF-8"?>
> 2: <!-- Copyright © 2016-2023 Andy Goryachev <andy at goryachev.com> -->
> 3: <!-- original source: https://github.com/andy-goryachev/FxTextEditor/blob/master/build.xml -->
Delete these two lines. The original source is not relevant, and any copyright should say "Oracle" (although this file probably doesn't need one).
-------------
PR Review: https://git.openjdk.org/jfx/pull/1097#pullrequestreview-1391921348
PR Review Comment: https://git.openjdk.org/jfx/pull/1097#discussion_r1171247193
PR Review Comment: https://git.openjdk.org/jfx/pull/1097#discussion_r1171247671
PR Review Comment: https://git.openjdk.org/jfx/pull/1097#discussion_r1171248828
More information about the openjfx-dev
mailing list