RFR: 8306464: [testbug] CustomSecurityManagerTest full screen tests fails on MacOS intermittently

Lukasz Kostyra lkostyra at openjdk.org
Thu Apr 20 11:05:54 UTC 2023


On Thu, 20 Apr 2023 08:36:59 GMT, Karthik P K <kpk at openjdk.org> wrote:

> Usage of `getBounds()` method instead `getVisualBounds()` was giving unreliable screen bound values and color value was read very close to the edge of the window.
> 
> Updated the code to use `getVisualBounds()` instead of `getBounds()` and moved the coordinates inside the window from where the color value is read.
> 
> Ran the tests individually and along with all system tests in following systems. No failure found after the fix.
> Mac M1 with Ventura 13.3
> Window 11

Changes look good to me.

I tested them on my M1 Max with 13.3.1 Ventura, ran both the tests themselves and the whole suite a couple times and it doesn't fail anymore. I think the problem is resolved.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1103#pullrequestreview-1393745626


More information about the openjfx-dev mailing list