RFR: 8303911: [testbug] Some unit tests call System.exit

Lukasz Kostyra lkostyra at openjdk.org
Thu Apr 20 11:09:54 UTC 2023


On Wed, 19 Apr 2023 19:24:09 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Changes added to this commit resolve cases where `System.exit()` was used to leave tests abruptly. These tests, if System.exit() is hit, could potentially create some unwanted behavior from JTest (ex. silently skipping these tests instead of failing them).
>> 
>> There were some files which I did not modify, mostly because they were a part of a test sub-app, or tests would require major rework to make it work.
>> 
>> Two FXML tests were performance tests already written as separate apps, so I moved them to appropriate directory in tests/performance.
>
> tests/system/src/test/java/test/com/sun/javafx/image/impl/ImageRaceTest.java line 129:
> 
>> 127:                     verbose = true;
>> 128:                 } else {
>> 129:                     fail("Unrecognized argument: "+arg);
> 
> maybe add spaces: "_+_arg

Could be done indeed while this line is edited.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1101#discussion_r1172433124


More information about the openjfx-dev mailing list