RFR: 8285878: [TestBug] LocalStorageTest and UserDataDirectoryTest don't always cleanup data dirs [v2]

Kevin Rushforth kcr at openjdk.org
Thu Apr 20 12:20:55 UTC 2023


On Wed, 19 Apr 2023 15:12:52 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

>> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data dirs"
>> Solution:
>> 1. All data directories must only be created under the "build" dir. In addition to being a best practice, at least they will be cleaned up by "gradle clean"
>> 2. There should be an @AfterClass method that deletes the data dirs
>> 3. There should be an @BeforeClass method that also deletes the data dirs prior to running the tests in case it wasn't cleaned up previously
>
> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1100#pullrequestreview-1393856901


More information about the openjfx-dev mailing list