RFR: 8303911: [testbug] Some unit tests call System.exit [v2]

Andy Goryachev angorya at openjdk.org
Thu Apr 20 15:56:52 UTC 2023


On Thu, 20 Apr 2023 11:17:26 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> Changes added to this commit resolve cases where `System.exit()` was used to leave tests abruptly. These tests, if System.exit() is hit, could potentially create some unwanted behavior from JTest (ex. silently skipping these tests instead of failing them).
>> 
>> There were some files which I did not modify, mostly because they were a part of a test sub-app, or tests would require major rework to make it work.
>> 
>> Two FXML tests were performance tests already written as separate apps, so I moved them to appropriate directory in tests/performance.
>
> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review issues, update copyright dates

looks good, thanks!

-------------

Marked as reviewed by angorya (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1101#pullrequestreview-1394310664


More information about the openjfx-dev mailing list