RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v2]

Kevin Rushforth kcr at openjdk.org
Sat Apr 22 14:44:51 UTC 2023


On Sat, 22 Apr 2023 13:24:54 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> I replicated the fix on #1054 on Linux.
>> 
>> Also fixes [Monocle: Stage no longer gets focus after fix for JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Request Focus on setVisible

I'll look at this early next week. My initial question for you is: Why wasn't the restored call to `requestFocus()` put back in the same place? It used to be in `setScene` and now is in `setVisible`. Was that change necessary?

I'd also like @jperedadnr to review this, since he was looking at [JDK-8304476](https://bugs.openjdk.org/browse/JDK-8304476), which was also caused by the fix for JDK-8296621. I would expect this new fix to also fix JDK-8304476.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1110#issuecomment-1518675964


More information about the openjfx-dev mailing list