RFR: 8306708: Region.layoutInArea uses incorrect snap scale value

John Hendrikx jhendrikx at openjdk.org
Mon Apr 24 05:08:52 UTC 2023


On Sun, 23 Apr 2023 20:26:08 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> In the following line, snapScaleX is used twice:
> 
> 
>     child.resize(snapSize(size.x, isSnapToPixel, snapScaleX),
>                  snapSize(size.y, isSnapToPixel, snapScaleX));
> 
> 
> Looks like a copy-and-paste bug.

Looks good.

Region also has `snapSizeX` and `snapSizeY` for this purpose that only require a single parameter.

The whole method is dealing with a lot more "snapping" than it really has to unfortunately.

-------------

Marked as reviewed by jhendrikx (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1112#pullrequestreview-1397191285


More information about the openjfx-dev mailing list