RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v5]

Jose Pereda jpereda at openjdk.org
Mon Apr 24 12:28:54 UTC 2023


On Sat, 22 Apr 2023 18:47:54 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> I replicated the fix on #1054 on Linux.
>> 
>> Also fixes [Monocle: Stage no longer gets focus after fix for JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change call to requestFocus

modules/javafx.graphics/src/main/java/javafx/stage/Stage.java line 1199:

> 1197: 
> 1198:             if (!isIconified()) {
> 1199:                 requestFocus();

As for Android, and as discussed earlier in comments, this delays a little bit the focus request from the original implementation before JDK-8296621, but it works fine (the stage gets focused), in line with the earlier proposed fix in MonocleWindow:


04-24 14:06:45.970 31436 31461 D GraalCompiled: (Original focus request, before JDK-8296621, in WindowStage::setScene)
04-24 14:06:46.395 31436 31461 D GraalCompiled: (Earlier proposed focus request in MonocleWindow::setVisible)
04-24 14:06:46.395 31436 31461 D GraalCompiled:  (Current focus request in Stage::doVisibleChanged)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1175209875


More information about the openjfx-dev mailing list