RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v6]

Thiago Milczarek Sayao tsayao at openjdk.org
Mon Apr 24 23:35:18 UTC 2023


On Mon, 24 Apr 2023 12:36:50 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 46 additional commits since the last revision:
>> 
>>  - Review changes
>>  - Merge branch 'master' into change_scene_fix
>>  - Change call to requestFocus
>>  - Revert "The window could start iconified."
>>    
>>    This reverts commit f92e25cbcc24fd772b9d6bb25a92386ec0561313.
>>  - The window could start iconified.
>>  - Request Focus on setVisible
>>  - fix mistake
>>  - Scene not rendered initially when changing scenes after fix for JDK-8296621
>>  - Merge branch 'openjdk:master' into master
>>  - Merge branch 'openjdk:master' into master
>>  - ... and 36 more: https://git.openjdk.org/jfx/compare/750bc278...2649d15c
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkWindow.java line 51:
> 
>> 49:     // empty - not needed by this implementation
>> 50:     @Override
>> 51:     protected void _updateViewSize(long ptr) {}
> 
> Remove the comment?

Removed it.

> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkWindow.java line 51:
> 
>> 49:     // empty - not needed by this implementation
>> 50:     @Override
>> 51:     protected void _updateViewSize(long ptr) {}
> 
> Fix copyright header of modified files

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1175872576
PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1175873176


More information about the openjfx-dev mailing list