RFR: 8302816: Refactor sorting-related classes [v2]

John Hendrikx jhendrikx at openjdk.org
Wed Apr 26 10:16:54 UTC 2023


On Wed, 26 Apr 2023 10:06:46 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Most of the changes revolve around unifying the sorting methods for a collection with `Comparable` elements with sorting methods that take an external `Comparator` by passing `Comparator.naturalOrder()` from the former to the latter. This eliminates method duplication and some warnings suppressions.
>> 
>> Note that I get 1 failing test: VersionInfoTest.testMajorVersion. This PR is unrelated to this test.
>
> Nir Lisker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Added missing space
>  - Merge branch 'master' into 8302816_Refactor_sorting-related_classes
>  - Initial commit

Marked as reviewed by jhendrikx (Committer).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1041#pullrequestreview-1401640853


More information about the openjfx-dev mailing list