RFR: 8296590: StraightLineTest fails always on Linux and sometimes on other platforms [v2]

Kevin Rushforth kcr at openjdk.org
Thu Apr 27 12:53:26 UTC 2023


On Thu, 27 Apr 2023 02:34:53 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

>> Issue: The test fails, in case snapshot is taken before web view finish web content load
>> Solution: Introduce a sleep , before taking snapshot of web view , to test straight line
>
> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   On Linux , text is warpping , so add style nowrap

The fix looks good, and works for me on Linux. By way of cleanup, please remove the comment with the Bug ID (see inline).

Minor: I think you can also remove the now-unused import of `org.junit.Assume.assumeFalse`.

tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line 110:

> 108: 
> 109:     @Test public void testLine() {
> 110:         // JDK-8296590

You need to remove this comment as well.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1115#pullrequestreview-1403944157
PR Review Comment: https://git.openjdk.org/jfx/pull/1115#discussion_r1179092095


More information about the openjfx-dev mailing list