RFR: 8299335: Monkey Tester Application [v13]

Karthik P K kpk at openjdk.org
Fri Apr 28 07:11:29 UTC 2023


On Thu, 27 Apr 2023 23:29:22 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Monkey Tester - a JavaFX application designed to support manual ad-hoc testing of individual JavaFX controls.  Unlike Ensemble, the goal of this application is to facilitate manual testing rather than demonstrate the capabilities of JavaFX.
>> 
>> Feedback and suggestions are always welcome.
>> 
>> ![screenshot](https://user-images.githubusercontent.com/107069028/232911797-3d02da68-ce11-419e-8f16-c2661b778f9c.png)
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   whitespace

Added couple of minor comments inline

tests/manual/monkey/src/com/oracle/tools/fx/monkey/pages/ChoiceBoxPage.java line 42:

> 40:         LONG,
> 41:         RIGHT_TO_LEFT,
> 42:     }

Minor: Unused enum could be removed.

tests/manual/monkey/src/com/oracle/tools/fx/monkey/pages/ComboBoxPage.java line 54:

> 52:             control.setConverter(new StringConverter() {
> 53:                 int toStringCounter = 0;
> 54:                 int fromStringCounter = 0;

Minor: Unused variables could be removed.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1097#pullrequestreview-1405342131
PR Review Comment: https://git.openjdk.org/jfx/pull/1097#discussion_r1180006922
PR Review Comment: https://git.openjdk.org/jfx/pull/1097#discussion_r1180007335


More information about the openjfx-dev mailing list