RFR: 8302816: Refactor sorting-related classes [v3]

Nir Lisker nlisker at openjdk.org
Fri Apr 28 11:41:53 UTC 2023


> Most of the changes revolve around unifying the sorting methods for a collection with `Comparable` elements with sorting methods that take an external `Comparator` by passing `Comparator.naturalOrder()` from the former to the latter. This eliminates method duplication and some warnings suppressions.
> 
> Note that I get 1 failing test: VersionInfoTest.testMajorVersion. This PR is unrelated to this test.

Nir Lisker has updated the pull request incrementally with two additional commits since the last revision:

 - Addressed review comments for SortableList
 - Addressed review comments for FXCollections

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1041/files
  - new: https://git.openjdk.org/jfx/pull/1041/files/a1e58804..36da565e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1041&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1041&range=01-02

  Stats: 5 lines in 2 files changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jfx/pull/1041.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1041/head:pull/1041

PR: https://git.openjdk.org/jfx/pull/1041


More information about the openjfx-dev mailing list