RFR: 8302816: Refactor sorting-related classes [v2]

Kevin Rushforth kcr at openjdk.org
Fri Apr 28 13:11:00 UTC 2023


On Fri, 28 Apr 2023 11:20:39 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> modules/javafx.base/src/main/java/com/sun/javafx/collections/ObservableListWrapper.java line 45:
>> 
>>> 43:  *
>>> 44:  */
>>> 45: public class ObservableListWrapper<E> extends ModifiableObservableListBase<E> implements SortableList<E>, RandomAccess {
>> 
>> Looks like an unintended change. Can be reverted.
>
> The formatter is set to 120 characters in a line, I think it's fine to leave as is.

If you were already modifying this, then sure. I don't think Ambarish's point was about the line being too long. In this case, the rewrapping is on otherwise unmodified lines of code, so is unrelated to your PR.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1041#discussion_r1180361762


More information about the openjfx-dev mailing list