RFR: 8302816: Refactor sorting-related classes [v3]
John Hendrikx
jhendrikx at openjdk.org
Sat Apr 29 09:00:26 UTC 2023
On Fri, 28 Apr 2023 11:41:53 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> Most of the changes revolve around unifying the sorting methods for a collection with `Comparable` elements with sorting methods that take an external `Comparator` by passing `Comparator.naturalOrder()` from the former to the latter. This eliminates method duplication and some warnings suppressions.
>>
>> Note that I get 1 failing test: VersionInfoTest.testMajorVersion. This PR is unrelated to this test.
>
> Nir Lisker has updated the pull request incrementally with two additional commits since the last revision:
>
> - Addressed review comments for SortableList
> - Addressed review comments for FXCollections
Marked as reviewed by jhendrikx (Committer).
-------------
PR Review: https://git.openjdk.org/jfx/pull/1041#pullrequestreview-1406904701
More information about the openjfx-dev
mailing list