RFR: 8260342: FXMLLoader fails to load a sub layout using fx:include with the resources attribute [v2]

[Guillaume Tâche]

On Tue, 1 Aug 2023 10:04:25 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Guillaume Tâche has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Empty commit
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1101:
> 
>> 1099:                         loadListener.readInternalAttribute(localName, value);
>> 1100:                     }
>> 1101:                     final ResourceBundle loaderResources = FXMLLoader.this.resources;
> 
> Why to have this local temporary `loaderResources`?
> We can simply use `this.resources` for readability.

Done.

> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1106:
> 
>> 1104:                     } else {
>> 1105:                         final ClassLoader cl = loaderResources.getClass().getClassLoader();
>> 1106:                         resources = cl == null ?
> 
> Add a bracket around `cl == null`

Done.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1158#discussion_r1281664467
PR Review Comment: https://git.openjdk.org/jfx/pull/1158#discussion_r1281664578