RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]
Andy Goryachev
angorya at openjdk.org
Thu Aug 3 18:07:42 UTC 2023
On Thu, 3 Aug 2023 04:06:04 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> When the JavaFX scene is set before it is really shown, then the scale factors are not properly propagated to the EmbeddedWindow, resulting in showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Call updateSceneState with lock and in FX thread
modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 826:
> 824: }
> 825: double newScaleFactorX = config.getDefaultTransform().getScaleX();
> 826: double newScaleFactorY = config.getDefaultTransform().getScaleY();
minor suggestion: create a method get[Current]Transform() to avoid code duplication (here and line 621)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1171#discussion_r1283538380
More information about the openjfx-dev
mailing list