RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v4]

Andy Goryachev angorya at openjdk.org
Thu Aug 3 19:30:40 UTC 2023


On Wed, 5 Jul 2023 19:30:21 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Modified the resize algorithm to work well with fractional scale, thanks for deeper understanding of the problem thanks to  @hjohn and @mstr2 .
>> 
>> It is important to note that even though the constraints are given by the user in unsnapped coordinates, they are converted to snapped values, since the snapped values correspond to the actual pixels on the display.  This means the tests that validate honoring constraints should, in all the cases where (scale != 1.0), assume possibly error not exceeding (1.0 / scale) (I think).
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - whitespace
>  - Merge remote-tracking branch 'origin/master' into 8299753.resize
>  - review comments
>  - review comments
>  - whitespace
>  - removed obsolete tester
>  - Merge remote-tracking branch 'origin/master' into 8299753.resize
>  - cleanup
>  - new algorithm

@kevinrushforth please take a look.  thanks!

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1156#issuecomment-1664515679


More information about the openjfx-dev mailing list