RFR: JDK-8187314: All Cells: must show backing data always
Kevin Rushforth
kcr at openjdk.org
Sat Aug 5 13:46:34 UTC 2023
On Fri, 4 Aug 2023 18:13:34 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
> Before, the `updateItem` method was called with the new value that was committed via `commitEdit()`.
> This is problematic as developers may setup a commit handler via `setOnEditCommit`, which may reject the edit (or change the value otherwise).
> We therefore do call the `updateItem(-1)` which will also call `updateItem` but with the real underlying value.
>
> Changed and added tests for all 4 cells.
This seems reasonable.
@aghaisas can you review it. It will need a second reviewer as well.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1197#issuecomment-1666510080
More information about the openjfx-dev
mailing list