RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v8]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Mon Aug 7 06:51:43 UTC 2023
On Fri, 4 Aug 2023 05:46:35 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> both windows (using EmbeddedFrameBug class listed earlier) shows O100% for primary retina screen (should be 200%).
@hjohn Seems like @andy-goryachev-oracle is telling it regressed after `updateSceneState` integration as previously he mentioned
https://github.com/openjdk/jfx/pull/1171#pullrequestreview-1522452579
> getting the scales right on both monitors now (macOS)
> the image is rendered with no gaps.
> LGTM
So, it seems scaling swing-interop fix with` stage.setRenderScaleX/Y `was solving JDK-8274932 but not JDK-8222209 whereas your fix is solving both in windows but not solving JDK-8274932 in mac..
Since this seems to be about windows-toolkit `updateSceneState` , probably it's best to take it out from this PR and let it have only swing-interop change with ` stage.setRenderScaleX/Y ` and remove JDK-8222209 from this PR..
What you both suggest?
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1171#issuecomment-1667283749
More information about the openjfx-dev
mailing list