RFR: 8310885: Width/height of window is not set after calling sizeToScene
Lukasz Kostyra
lkostyra at openjdk.org
Mon Aug 7 14:15:38 UTC 2023
On Thu, 3 Aug 2023 14:57:50 GMT, Guillaume Tâche <duke at openjdk.org> wrote:
> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and before `show()`.
> Now the `sizeToScene` flag is unset in these methods to ensure the right values are set when the window is shown.
Overall LGTM, tests pass on Windows and macOS.
Left out a minor comment, but it's not a deal-breaker.
modules/javafx.graphics/src/test/java/test/javafx/stage/WindowTest.java line 85:
> 83: }
> 84:
> 85: @Test
Minor - I think it would be best to keep old code untouched to not mix up the file history in Git, should we ever need it.
-------------
PR Review: https://git.openjdk.org/jfx/pull/1195#pullrequestreview-1565359901
PR Review Comment: https://git.openjdk.org/jfx/pull/1195#discussion_r1285920644
More information about the openjfx-dev
mailing list