RFR: 8310885: Width/height of window is not set after calling sizeToScene [v2]

Guillaume Tâche duke at openjdk.org
Tue Aug 8 09:02:07 UTC 2023


On Mon, 7 Aug 2023 15:18:48 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.graphics/src/test/java/test/javafx/stage/WindowTest.java line 85:
>> 
>>> 83:     }
>>> 84: 
>>> 85:     @Test
>> 
>> Minor - I think it would be best to keep old code untouched to not mix up the file history in Git, should we ever need it.
>
> Good suggestion. The following sentence from the [code style section of the CONTRIBUTING guidelines](https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md#coding-style-and-testing-guidelines) provides this advice:
> 
> * Avoid making changes that are unrelated to the bug you are fixing. This includes fixing minor errors such as warnings, spacing / indentation, spelling errors, etc, in code that you aren't otherwise modifying as part of your fix.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1195#discussion_r1286821171


More information about the openjfx-dev mailing list