RFR: JDK-8313799: Remove lockItemOnEdit flag from (Tree)TableCell
Ajit Ghaisas
aghaisas at openjdk.org
Tue Aug 8 11:36:38 UTC 2023
On Fri, 4 Aug 2023 22:12:55 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
> The `lockItemOnEdit` only exists inside `TreeTableCell` and `TableCell` for the sake of testing.
> It is only changed by some JUnit tests to remove the need of setting up the whole table framework.
> This PR shifts this flag from those two classes to the shim classes, which are not inside the final JavaFX product, only used for testing.
Thanks for fixing it.
This is a good cleanup!
-------------
Marked as reviewed by aghaisas (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1198#pullrequestreview-1567094257
More information about the openjfx-dev
mailing list