RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element [v2]

[Kevin Rushforth]

On Tue, 8 Aug 2023 16:09:58 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

>> Issue : Enabling modern media controls on webkit 616.1 does not load button images on HTML5 Video Element
>> Solution: Add resources and correct MediaControl Stylesheet
>
> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   clean up according to review comments

The updates look good with two remaining comments.

Here is the screen shot that shows the clipping in the example test program.

![HTML5VideoControlTest](https://github.com/openjdk/jfx/assets/34689748/9183c8e6-5c7e-4c42-98b9-8e7451cdcbb7)

modules/javafx.web/src/main/native/Source/WebCore/platform/java/ModernMediaControlResource.cpp line 28:

> 26: #include "ModernMediaControlResource.h"
> 27: 
> 28: ModernMediaControlResource::ModernMediaControlResource() {

Can you add a comment indicating that the Base64 images in this file were generated from the resources in `WebCore/Modules/modern-media-controls/images/adwaita/` using the `Tools/Scripts/generate_icon_resource.py` script?

-------------

PR Review: https://git.openjdk.org/jfx/pull/1201#pullrequestreview-1567727729
PR Review Comment: https://git.openjdk.org/jfx/pull/1201#discussion_r1287393457