RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element [v2]
Kevin Rushforth
kcr at openjdk.org
Tue Aug 8 16:48:44 UTC 2023
On Tue, 8 Aug 2023 16:04:58 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:
>> tests/manual/web/HTML5VideoControlTest.java line 48:
>>
>>> 46:
>>> 47: HBox content = new HBox();
>>> 48: content.getChildren().addAll(createInstructionsBox(), webView); // Swap the order here
>>
>> Is the comment meant to suggest a follow-up action or ... ?
>
> it is follow up
But why? What is the reason you want to make the change? I don't see it as needed.
More to the point, it is probably better to add the instructions to the root `VBox` either above or below the WebView. As it is, the instructions are truncated. See the attached image.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1201#discussion_r1287398456
More information about the openjfx-dev
mailing list