RFR: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element [v2]

Jay Bhaskar jbhaskar at openjdk.org
Tue Aug 8 17:39:23 UTC 2023


On Tue, 8 Aug 2023 17:33:29 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

>> modules/javafx.web/src/main/native/Source/WebCore/platform/java/ModernMediaControlResource.cpp line 28:
>> 
>>> 26: #include "ModernMediaControlResource.h"
>>> 27: 
>>> 28: ModernMediaControlResource::ModernMediaControlResource() {
>> 
>> Can you add a comment indicating that the Base64 images in this file were generated from the resources in `WebCore/Modules/modern-media-controls/images/adwaita/` using the `Tools/Scripts/generate_icon_resource.py` script?
>
> done

done

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1201#discussion_r1287449379


More information about the openjfx-dev mailing list