RFR: JDK-8312058: Documentation improvements for subscription based listeners [v4]

Nir Lisker nlisker at openjdk.org
Fri Aug 11 14:30:59 UTC 2023


On Fri, 11 Aug 2023 12:12:28 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Incorporates documentation review comments from #1069.
>> 
>> This PR should be kept minimal so it can be backported to JFX21; it should only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update Subscription documentation wording and add example

modules/javafx.base/src/main/java/javafx/util/Subscription.java line 33:

> 31: /**
> 32:  * Represents a cancel or cleanup operation for an action be cancelled or
> 33:  * allocated resources. Subscriptions can be obtained, for example, as a result

Somethign is missing in the sentence, should it be "...for an action that can be cancelled or that allocates resources"

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1177#discussion_r1291402025


More information about the openjfx-dev mailing list