RFR: 8307316: Let JavaFX be built on unknown architectures [v3]

Kevin Rushforth kcr at openjdk.org
Fri Aug 11 18:25:59 UTC 2023


On Thu, 10 Aug 2023 23:56:58 GMT, John Neffenger <jgneff at openjdk.org> wrote:

>> Please review these changes to the Gradle build files and the dependency verification file. The initial version of this pull request extends the permitted build platforms for Linux to the Java architectures `arm`, `ppc64le`, and `s390x` and adds an entry to the dependency verification file for the `i386` architecture. The Debian names for these architectures are `armhf`, `i386`, `ppc64el`, and `s390x`.
>
> John Neffenger has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge branch 'master' into allow-armhf-i386-ppc64el-s390x
>  - Merge branch 'master' into allow-armhf-i386-ppc64el-s390x
>  - Warn instead of failing on unknown architectures
>  - Merge branch 'master' into allow-armhf-i386-ppc64el-s390x
>  - Merge branch 'master' into allow-armhf-i386-ppc64el-s390x
>  - Allow building on armhf, i386, ppc64el, and s390x

The changes look good. I did a quick test and it does what I would expect.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1124#pullrequestreview-1574171335


More information about the openjfx-dev mailing list