RFR: 8314149: Clipboard does inexact string comparison on mime type [v2]
Ambarish Rapte
arapte at openjdk.org
Mon Aug 14 09:27:02 UTC 2023
On Fri, 11 Aug 2023 12:10:01 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> The code change looks good. However, the new test passes for me either with or without your fix.
Hi Kevin, I re-looked into the test. The test seems to be insufficient to test the change.
That test and other test in the file ClipboardContentTest, only verify if there are expected entries in the ClipboardContent map and does not verify whole copy functionality to the level of system clipboard, hence removed the test.
I think adding a test that verifies this may be an overkill for the change we are making here and would like to skip adding a test. Does that sound ok ?
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1207#issuecomment-1676961892
More information about the openjfx-dev
mailing list