RFR: 8309558: Create implementation of NSAccessibilityCheckBox protocol [v2]

Alexander Zuev kizune at openjdk.org
Mon Aug 14 18:49:49 UTC 2023


On Mon, 7 Aug 2023 14:10:09 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line 174:
>> 
>>> 172:     jobject jresult = NULL;
>>> 173:     GET_MAIN_JENV;
>>> 174:     if (env == NULL) return NULL;
>> 
>> This generates a warning:
>> `warning: incompatible pointer to integer conversion returning 'void *' from a function with result type 'BOOL' (aka 'signed char') [-Wint-conversion]`
>
> Good catch. This should probably be changed to: `return NO;`

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1184#discussion_r1293844536


More information about the openjfx-dev mailing list