RFR: 8310885: Width/height of window is not set after calling sizeToScene [v2]

Michael Strauß mstrauss at openjdk.org
Wed Aug 16 04:45:17 UTC 2023


On Tue, 8 Aug 2023 09:02:07 GMT, Guillaume Tâche <duke at openjdk.org> wrote:

>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and before `show()`.      
>> Now the `sizeToScene` flag is unset in these methods to ensure the right values are set when the window is shown.
>
> Guillaume Tâche has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8310885: Fixes review comment

I agree that `sizeToScene` should be reset when the width or height is manually set. The patch works as expected.

-------------

Marked as reviewed by mstrauss (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1195#pullrequestreview-1579788287


More information about the openjfx-dev mailing list